[tests] deflake DartServerHighlightingTest.testNavigationTargetOffsetUpdated
#93
Conversation
Summary of ChangesHello @pq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses flakiness in DartServerHighlightingTest.testNavigationTargetOffsetUpdated by introducing a call to myFixture.doHighlighting(). This change is a solid approach to synchronize the test with the IntelliJ platform's asynchronous operations. By waiting for highlighting to complete, the test ensures that document changes triggered by myFixture.type() are fully processed by the EDT and the Dart Analysis Server before the assertions are executed. This effectively mitigates the race condition that was likely causing the test to be flaky. The change is correct and aligns with common practices for writing robust integration tests in this framework.
|
I'm not sure this entirely deflakes the test but it feels like a step in the right direction. |
2 participants
An attempt at hardening
DartServerHighlightingTest.testNavigationTargetOffsetUpdated.The rub is to ensure EDT thread actions have been run out before we make assertions about keystrokes that haven't been propagated yet. If I understand the
doHighlighting()API, it may do the trick? 🤞(Kind of a stab in the dark but it's plausible (and familiar from other integration test experiences).)
Contribution guidelines:
dart format.